Remove 'static bound from sync::mpsc, Mutex and RwLock.
#22574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
huonw
force-pushed
the
remove-lame-statics
branch
from
9eaf9a0 to
299cdc9
Compare
4 tasks
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 20, 2015
This commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.
| @@ -64,8 +64,8 @@ pub struct RwLock<T> { | |||
| data: UnsafeCell<T>, | |||
| } | |||
|
|
|||
| unsafe impl<T:'static+Send> Send for RwLock<T> {} | |||
| unsafe impl<T> Sync for RwLock<T> {} | |||
There was a problem hiding this comment.
I'm... a little shocked by this!
There was a problem hiding this comment.
I was also surprised that RwLock previously had such loose bounds, however, I think it was impossible to construct one that didn't satisfy them, so it has probably not mattered (fortunately).
|
The changes to |
huonw
force-pushed
the
remove-lame-statics
branch
from
299cdc9 to
1fd17f7
Compare
|
Ok I talked with @aturon tonight and he agreed that this should be ok. r=me with the new test case to trigger an error in the |
Adds some basic tests to check that the types still catch the most glaring errors that could occur. cc rust-lang#22444.
huonw
force-pushed
the
remove-lame-statics
branch
from
1fd17f7 to
380d23b
Compare
|
@bors r=alexcirchton 380d |
|
⌛ Testing commit 380d23b with merge dcc6ce2... |
bors
added a commit
that referenced
this pull request
Feb 22, 2015
Add a basic test that checks that the types catch the most glaring errors that could occur. cc #22444
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
This commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic test that checks that the types catch the most glaring
errors that could occur.
cc #22444