Skip to content

updating llvm and jemalloc submodules to include bitrig support #23006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2015
Merged

updating llvm and jemalloc submodules to include bitrig support #23006

merged 5 commits into from
Mar 6, 2015

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Mar 3, 2015

as the subject says.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@dhuseby
Copy link
Author

dhuseby commented Mar 3, 2015

@alexcrichton @brson I'm pretty sure I did this correctly.

@alexcrichton
Copy link
Member

@bors: r+ 1329dc6e8f328d91a4c6499483a0f00f8302d2d5

Thanks!

@alexcrichton
Copy link
Member

@bors: rollup

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

@alexcrichton I added the bump in the jemalloc revision too. almost there!

@alexcrichton
Copy link
Member

I had to check in an extra commit to jemalloc to propagate your changes to the generated configure script, so you may want to pin the submodule to rust-lang/jemalloc@e24a1a0 instead

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

ah, k. let me do that.

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

@alexcrichton done.

@alexcrichton
Copy link
Member

@bors: r+ 710b054

@alexcrichton
Copy link
Member

@bors: rollup

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

@alexcrichton alright, now the only thing left is to get my latest bitrig rust snapshots into static.rust-lang.org/dl/ How do I do that?

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

and then I can add it to the src/snapshots.txt file

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

@dhuseby dhuseby changed the title updating llvm submodule to include bitrig support updating llvm and jemalloc submodules to include bitrig support Mar 4, 2015
@alexcrichton
Copy link
Member

I've uploaded your snapshots

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

I just rebased to current rust master.

@alexcrichton
Copy link
Member

@bors: r+ bcd6076

@dotdash
Copy link
Contributor

dotdash commented Mar 4, 2015

@bors r-

Sorry to r-, but you must also update src/rustllvm/llvm-auto-clean-trigger. This is required for the buildbots to actually build the new llvm version.

@dhuseby
Copy link
Author

dhuseby commented Mar 4, 2015

@dotdash @alexcrichton updated llvm-auto-clean-trigger per review feedback.

@dotdash
Copy link
Contributor

dotdash commented Mar 4, 2015

@bors r=alexcrichton e0a0b46

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2015
@bors bors merged commit e0a0b46 into rust-lang:master Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants