rustdoc: Relocate array primitive docs to a new page #23633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
tomjakubowski
force-pushed
the
rustdoc-array-prim
branch
from
8945dd6 to
7684012
Compare
| @@ -1322,7 +1322,8 @@ pub enum Type { | |||
| /// For parameterized types, so the consumer of the JSON don't go | |||
| /// looking for types which don't exist anywhere. | |||
| Generic(String), | |||
| /// Primitives are just the fixed-size numeric types (plus int/uint/float), and char. | |||
| /// Primitives are the fixed-size numeric types (plus int/uint/float), char, | |||
| /// arrays, slices, and types. | |||
There was a problem hiding this comment.
this has an extra 'and types'. Maybe 'tuple' was meant?
|
Also, you should squash these two together, don't want my 'wip' commit getting into the history :) |
|
r=me with a squash |
Impls on `clean::Type::FixedVector` are now collected in the array primitive page instead of the slice primitive page. Also add a primitive docs for arrays to `std`.
tomjakubowski
force-pushed
the
rustdoc-array-prim
branch
from
7684012 to
2df8830
Compare
|
Squashed and addressed the typo @steveklabnik found |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
Previously, impls for `[T; n]` were collected in the same place as impls for `[T]` and `&[T]`. This splits them out into their own primitive page in both core and std.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, impls for
[T; n]were collected in the same place as impls for[T]and&[T]. This splits them out into their own primitive page in both core and std.