std: Set overlap/noinherit flags on windows sockets #24211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Would it be appropriate to extend the docs to indicate that these are on by default? |
|
Hm I definitely think it would be appropriate! I'm not quite sure where said docs would go though as we don't currently have many platform-specific docs. Would you be ok if I opened a bug in the meantime for this topic? |
| @@ -44,6 +44,8 @@ pub const WSA_WAIT_TIMEOUT: libc::DWORD = libc::consts::os::extra::WAIT_TIMEOUT; | |||
| pub const WSA_WAIT_EVENT_0: libc::DWORD = libc::consts::os::extra::WAIT_OBJECT_0; | |||
| pub const WSA_WAIT_FAILED: libc::DWORD = libc::consts::os::extra::WAIT_FAILED; | |||
| pub const WSAESHUTDOWN: libc::c_int = 10058; | |||
| pub const WSA_FLAG_OVERLAPPED: libc::DWORD = 0x4; | |||
| pub const WSA_FLAG_NO_HANDLE_INHERIT: libc::DWORD = 0x8; | |||
There was a problem hiding this comment.
These are incorrect
#define WSA_FLAG_OVERLAPPED 0x01
#define WSA_FLAG_NO_HANDLE_INHERIT 0x80This commit modifies the socket creation functions on windows to always specify the `WSA_FLAG_OVERLAPPED` and `WSA_FLAG_NO_HANDLE_INHERIT` flags by default. The overlapped flag enables IOCP APIs on Windows to be used with the socket at no cost, enabling better interoperation with external libraries. The no handle inherit flag mirrors the upcoming change to Unix to set CLOEXEC by default for all handles. Closes rust-lang#24206
alexcrichton
force-pushed
the
windows-wsa-flag-overlapped
branch
from
9013a57 to
433f0e8
Compare
|
r? @aturon |
|
re: docs, I believe we discussed having a "Platform behavior" subsection as part of the IO audit. But yes, this can wait for that sweep. Meanwhile, @bors: r+ |
|
📌 Commit 433f0e8 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 15, 2015
…uron This commit modifies the socket creation functions on windows to always specify the `WSA_FLAG_OVERLAPPED` and `WSA_FLAG_NO_HANDLE_INHERIT` flags by default. The overlapped flag enables IOCP APIs on Windows to be used with the socket at no cost, enabling better interoperation with external libraries. The no handle inherit flag mirrors the upcoming change to Unix to set CLOEXEC by default for all handles. Closes #24206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the socket creation functions on windows to always specify
the
WSA_FLAG_OVERLAPPEDandWSA_FLAG_NO_HANDLE_INHERITflags by default. Theoverlapped flag enables IOCP APIs on Windows to be used with the socket at no
cost, enabling better interoperation with external libraries. The no handle
inherit flag mirrors the upcoming change to Unix to set CLOEXEC by default for
all handles.
Closes #24206