-
Notifications
You must be signed in to change notification settings - Fork 13.3k
std: Stabilize Clone::clone_from #24215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This method hasn't really changed since is inception, and it can often be a nice performance win for some situations. This method also imposes no burden on implementors or users of `Clone` as it's just a default method on the side.
r? @aturon |
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ It's time. |
📌 Commit 6b32072 has been approved by |
Out of curiosity, are there any consumers of |
…r=aturon This method hasn't really changed since is inception, and it can often be a nice performance win for some situations. This method also imposes no burden on implementors or users of `Clone` as it's just a default method on the side.
@sfackler none that I'm personally aware of, no |
@alexcrichton I thought this was instigated because of a request for stabilization by someone who needed it for performance? |
The original request came from @mzabaluev. @mzabaluev perhaps you could shed some light on your thoughts here? |
…r=aturon This method hasn't really changed since is inception, and it can often be a nice performance win for some situations. This method also imposes no burden on implementors or users of `Clone` as it's just a default method on the side.
An implementation of a type that encapsulates pointers to allocated or refcounted data could implement The user of |
This method hasn't really changed since is inception, and it can often be a
nice performance win for some situations. This method also imposes no burden on
implementors or users of
Clone
as it's just a default method on the side.