Make casts follow the new RFC401 #24333
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
ping @nrc, not r? yet |
|
r? @nrc (just making sure all PRs have an assignee) |
arielb1
force-pushed
the
implement-rfc401
branch
from
9c8fa8b to
1e9ed94
Compare
|
This is based on top of #24615 so I can test it faster. I will rebase before r? anyway. |
arielb1
force-pushed
the
implement-rfc401
branch
from
177251b to
1529183
Compare
|
☔ The latest upstream changes (presumably #25038) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm sorry for the disruption, I didn't know this was in the works. My patch was small, so it should be simple. |
|
I'm throwing the code out anyway. Shouldn't matter |
arielb1
changed the title
arielb1
force-pushed
the
implement-rfc401
branch
2 times, most recently
from
13c4999 to
c158bb4
Compare
|
r? @nrc Wow there were so many bugs here. |
|
☔ The latest upstream changes (presumably #24619) made this pull request unmergeable. Please resolve the merge conflicts. |
arielb1
force-pushed
the
implement-rfc401
branch
3 times, most recently
from
8a146e4 to
74e2bc5
Compare
|
|
||
| fn illegal_cast_2<U:?Sized>(u: *const U) -> *const str | ||
| { | ||
| u as *const str //~ ERROR vtable kinds |
There was a problem hiding this comment.
could you add a test for *const str as *const U (or something similar)?
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: r=nrc p=1 force |
|
📌 Commit e2f5f1b has been approved by |
|
⌛ Testing commit e2f5f1b with merge 32d0328... |
|
💔 Test failed - auto-win-32-nopt-t |
This should hopefully fix all cast-related ICEs once and for all. I managed to make diagnostics hate me and give me spurious "decoder error" - removing $build/tmp/extended-errors seems to fix it.
I think I didn't run tests properly - my second call to select_all_obligations_or_error has made 3 tests fail. However, this is just an error message change - integer fallback never worked with casts.
|
Fixed test failure |
|
Thanks @dotdash |
|
@bors r=nrc |
|
📌 Commit e7e1fd2 has been approved by |
No description provided.