Skip to content

rustdoc: change color of trait types #24804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Conversation

liigo
Copy link
Contributor

@liigo liigo commented Apr 25, 2015

Fixes #24441

Preview:
new-trait-color

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r? @steveklabnik

(not much of a UI guy)

@ftxqxd
Copy link
Contributor

ftxqxd commented Apr 27, 2015

I personally much prefer the old colour. I’d say that #24441 is really more of a bug in Chrome than anything else—Chrome really shouldn’t expect every website to avoid using a text colour that is close to the orange it uses to highlight search results.

@steveklabnik
Copy link
Member

I am not a UX person either, so I don't know. I do know that I didn't like the old color much. Let's see how we feel about this, it's always easy to fix to another color if it looks too weird.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2015

📌 Commit 31c3e7e has been approved by steveklabnik

bors added a commit that referenced this pull request Apr 27, 2015
@bors bors merged commit 31c3e7e into rust-lang:master Apr 27, 2015
@gkoz
Copy link
Contributor

gkoz commented May 12, 2015

I personally much prefer the old colour. I’d say that #24441 is really more of a bug in Chrome than anything else

Ditto. This feels like a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: Searching traits in Chrome got color confused
7 participants