-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: change color of trait types #24804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
(not much of a UI guy) |
I personally much prefer the old colour. I’d say that #24441 is really more of a bug in Chrome than anything else—Chrome really shouldn’t expect every website to avoid using a text colour that is close to the orange it uses to highlight search results. |
I am not a UX person either, so I don't know. I do know that I didn't like the old color much. Let's see how we feel about this, it's always easy to fix to another color if it looks too weird. |
@bors: r+ rollup |
📌 Commit 31c3e7e has been approved by |
Ditto. This feels like a regression. |
Fixes #24441
Preview:
