Add detailed error message for E0265 #24894
Conversation
This error indicates that a constant references itself. All constants need to resolve to a value in an acyclic manner. For example, neither of the following can be sensibly compiled: ``` const X: u32 = X; ``` ``` const X: u32 = Y; const Y: u32 = X; ```
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Ignore the branch name - the message is for |
|
Parent issue: #24407 |
|
@alexcrichton This is my first contribution to rustc, I assume that this means that it is getting merged? |
|
@bguiz it does indeed! We've got a bot which tests each PR serially and then will merge into master once all the tests pass. You can see the current status of the queue here: http://buildbot.rust-lang.org/homu/queue/rust. |
|
@alexcrichton Ah Ok, thanks for the update! On 29 April 2015 at 11:34, Manish Goregaokar [email protected] wrote:
|
This error indicates that a constant references itself. All constants need to resolve to a value in an acyclic manner. For example, neither of the following can be sensibly compiled: ``` const X: u32 = X; ``` ``` const X: u32 = Y; const Y: u32 = X; ```
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 1335be3 with merge ed34760... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 1335be3 with merge b1a621b... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Wed, Apr 29, 2015 at 7:52 AM, bors [email protected] wrote:
|
|
@bors rollup right? surely this qualifies |
This error indicates that a constant references itself. All constants need to resolve to a value in an acyclic manner. For example, neither of the following can be sensibly compiled: ``` const X: u32 = X; ``` ``` const X: u32 = Y; const Y: u32 = X; ```
|
The build failed, from the logs, Is it possible that someone else's commit was lumped together with mine? |
|
@bguiz: I think it's just a random failure. The rebuild will most likely succeed. |
|
@michaelsproul Looks like the build also timed out, and was killed after 1200 seconds |
|
Yay 🎈 |
|
Finally, took just under two days! |
This error indicates that a constant references itself.
All constants need to resolve to a value in an acyclic manner.
For example, neither of the following can be sensibly compiled: