Skip to content

make diagnostic message clearer when called from cargo #25381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2015

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented May 13, 2015

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! Our error messages conventionally start with lowercase letters instead of uppercase, so could this say "run rustc ..." instead of "Run rustc"? Other than that though this looks good to me!

@mathroc
Copy link
Contributor Author

mathroc commented May 13, 2015

alright it's done. I didn't squashed it as asked from the @rust-highfive bot. if you like it better squashed as it such a small edit, just tell me :)

@alexcrichton
Copy link
Member

r+ from me with a squash

@mathroc
Copy link
Contributor Author

mathroc commented May 13, 2015

and it's squashed

@alexcrichton
Copy link
Member

@bors: r+ 5f932e8 rollup

Thanks!

@bors
Copy link
Collaborator

bors commented May 14, 2015

⌛ Testing commit 5f932e8 with merge af52207...

Manishearth added a commit to Manishearth/rust that referenced this pull request May 14, 2015
@alexcrichton
Copy link
Member

Looks like one of the bots disappeared and then buildbot got hung up, everything passed, though, on many platforms, so I'm going to merge this manually.

@alexcrichton alexcrichton merged commit 5f932e8 into rust-lang:master May 14, 2015
@mathroc mathroc deleted the patch-1 branch May 14, 2015 18:02
bors added a commit that referenced this pull request May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo directly piping rustc output generates confusion with --explain
5 participants