-
Notifications
You must be signed in to change notification settings - Fork 13.3k
trpl: Proofread "Rust Inside Other Languages" #25464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
I can't seem to add a line comment to unchanged lines, but this is for L140.
Is this correct? Adding a test for |
☔ The latest upstream changes (presumably #25463) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict |
Thank you! I have some nits, but otherwise, this looks great :) |
I'm going to assume that all of the nits have been addressed, since it seems like the commit has been rebased. @steveklabnik , let me know my forthcoming r+ is off-base (given your prior comment). |
@bors r=steveklabnik |
📌 Commit 5a1e6df has been approved by |
r? @steveklabnik