Skip to content

Fix footnote link on "The stack and the heap" page #25601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2015
Merged

Fix footnote link on "The stack and the heap" page #25601

merged 1 commit into from
May 21, 2015

Conversation

ericye16
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 19, 2015

📌 Commit 4bc8853 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you! 😄

@pnkfelix
Copy link
Member

a merge commit has somehow gotten mixed in here?

@ericye16
Copy link
Contributor Author

Oops, I messed up. Should I try to revert that or should I just make a new
PR?

On Thu, May 21, 2015, 07:55 Felix S Klock II [email protected]
wrote:

a merge commit has somehow gotten mixed in here?


Reply to this email directly or view it on GitHub
#25601 (comment).

@ericye16
Copy link
Contributor Author

I fixed the merge commit via force push, next time I'll branch properly :)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 21, 2015

📌 Commit 4bc8853 has been approved by steveklabnik

@steveklabnik
Copy link
Member

(unsure if bors needs the re-r+, but doing it anyway just in case)

@bors
Copy link
Collaborator

bors commented May 21, 2015

⌛ Testing commit 4bc8853 with merge 7044f4a...

bors added a commit that referenced this pull request May 21, 2015
@bors bors merged commit 4bc8853 into rust-lang:master May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants