Rollup of 11 pull requests #25605
Merged
Rollup of 11 pull requests #25605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source code uses `"whatever".as_bytes()`, not `b"whatever"`.
The byte string literal syntax `b"whatever"` is more idiomatic than `"whatever".as_bytes()`.
That way old versions won't be a subsections of the 1.0.0 release.
Minor typo/grammar error.
This adds strictly more information to the source files and reduces the need for customized tooling to render the book. (While this should not change the output of _rustbook_, it is very useful when rendering the sources with external tools like Pandoc.)
`{rust,ignore}` -> `rust,ignore
Fixes rust-lang#24655 Margin for associated types was applied to type aliases (in return value) by mistake.
fixed a mistake.
Minor tweak: the text explaining the Borrow trait talks about slices, but the example immediately following just uses a simple reference; there are no slices involved. r? @steveklabnik
…excrichton The source code snippet uses `"whatever".as_bytes()` but the compilation error message uses `b"whatever"`. Both should be consistent with each other. r? @steveklabnik
…toc, r=alexcrichton Currently the table of contents for `rustbook` doesn't signify which page you are on. This PR adds an 'active' class to the link for the current page, and defines the CSS rule for that class to make the link underlined and bold. Not sure about two things: 1) Is `current_page` is a good name for the function parameter? At first I thought `current_item` would be good, but then in the `walk_item` function, you'd have `item` and `current_item`. 2) For the CSS, is both bold and underline too much? At first I had it just be underlined, but that's also how the links look when they're hovered over.
That way old versions won't be a subsections of the 1.0.0 release.
Looks like this was an issue in the source material. I've let the editor know and he has told me he is correcting it there as well. r? @steveklabnik
This has been a frequently-asked question on IRC, and it isn't obvious where to look for the fix. r? @steveklabnik
…=steveklabnik This adds strictly more information to the source files and reduces the need for customized tooling to render the book. (While this should not change the output of _rustbook_, it is very useful when rendering the sources with external tools like Pandoc.) This only adds the language marker to "first level" code blocks (and not to code blocks in comments inside of code examples). r? @steveklabnik
…ichton rustdoc: Fix left margin for type aliases Fixes rust-lang#24655 Margin for associated types was applied to type aliases (in return value) by mistake.
…cs, r=Manishearth Part of rust-lang#24407. This covers various errors to do with struct and enum patterns.
fixed a mistake.
|
@bors: r+ p=20 |
|
📌 Commit 3bb54a3 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustMarker to Some Code Block #25580, Fix left margin for type aliases #25587, Explain E0023, E0024, E0025, E0026, E0027, E0033. #25590, Update iter.rs #25591