Skip to content

Add logo to HTML docs #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2012
Merged

Add logo to HTML docs #2562

merged 2 commits into from
Jun 20, 2012

Conversation

killerswan
Copy link
Contributor

This adds the logo to the HTML versions of the docs, via CSS.
rust logo 128x128

@brson
Copy link
Contributor

brson commented Jun 11, 2012

This is a worthy idea but in my opinion the proposed style is not an aesthetic improvement (not that the existing style is attractive to begin with) because it adds too much useless whitespace. It also adds the rust logo to all subpages, so for example core::vec has a rust logo at the top. Additionally, any rust project that uses our style sheets will have a rust logo on their rustdocs.

For others' reference here's a screenshot: https://imgur.com/BJLkU

@killerswan
Copy link
Contributor Author

I do think it is an improvement, and I did intend it to show up on the subpages.

Compare this with other projects' HTML documentation, which typically includes a logo and much more graphical customization:
http://nodejs.org/api/tls.html
http://clojure.org/Protocols
http://perldoc.perl.org/functions/crypt.html
http://docs.python.org/library/string.html
http://hackage.haskell.org/packages/archive/yesod/1.0.1.6/doc/html/Yesod.html

There are a lot of invasive changes we could make to more comprehensively style the pages, but I think just sticking a simple monochrome logo at the top goes a long way with minimal trouble. It will be trivial for us or other projects to replace or modify this small stylesheet later.

@graydon
Copy link
Contributor

graydon commented Jun 13, 2012

I think if you want to put an em-height logo at the right hand side of the main header or something (more like the size of the python and haskell logos embedded in their pages), that'd be ok. I agree with @brson though that the proposed change chews up too much blank space.

@killerswan
Copy link
Contributor Author

How's this?
with logo

@brson
Copy link
Contributor

brson commented Jun 20, 2012

That's kind of cute!

brson added a commit that referenced this pull request Jun 20, 2012
@brson brson merged commit 8395305 into rust-lang:master Jun 20, 2012
@brson
Copy link
Contributor

brson commented Jun 20, 2012

Thanks for your patience!

oli-obk pushed a commit to oli-obk/rust that referenced this pull request Sep 28, 2022
Add flag to specify the number of cpus

Apparently you can't rename a branch from github's website without it closing all your PRs with that branch. So this is  just rust-lang#2545
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Oct 4, 2022
Add flag to specify the number of cpus

Apparently you can't rename a branch from github's website without it closing all your PRs with that branch. So this is  just rust-lang#2545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants