-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add logo to HTML docs #2562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo to HTML docs #2562
Conversation
This is a worthy idea but in my opinion the proposed style is not an aesthetic improvement (not that the existing style is attractive to begin with) because it adds too much useless whitespace. It also adds the rust logo to all subpages, so for example For others' reference here's a screenshot: https://imgur.com/BJLkU |
I do think it is an improvement, and I did intend it to show up on the subpages. Compare this with other projects' HTML documentation, which typically includes a logo and much more graphical customization: There are a lot of invasive changes we could make to more comprehensively style the pages, but I think just sticking a simple monochrome logo at the top goes a long way with minimal trouble. It will be trivial for us or other projects to replace or modify this small stylesheet later. |
I think if you want to put an em-height logo at the right hand side of the main header or something (more like the size of the python and haskell logos embedded in their pages), that'd be ok. I agree with @brson though that the proposed change chews up too much blank space. |
That's kind of cute! |
Thanks for your patience! |
Add flag to specify the number of cpus Apparently you can't rename a branch from github's website without it closing all your PRs with that branch. So this is just rust-lang#2545
Add flag to specify the number of cpus Apparently you can't rename a branch from github's website without it closing all your PRs with that branch. So this is just rust-lang#2545
This adds the logo to the HTML versions of the docs, via CSS.
