Rollup of 5 pull requests #25670
Closed
Rollup of 5 pull requests #25670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
May 21, 2015
Manishearth
commented
- Successful merges: use posix command to extract first 8 chars #25648, doc: that did not render well, so make it fit in one line #25659, Change "must" to "may only" in macro future proofing rules. #25661, Fix the typo in The Rust Programming Language book, 5.18. Strings #25665, Typo fix #25669
- Failed merges:
the "-c" option of head isn't a posix option, and it isn't supported under openbsd. prefer the use of cut -c 1-8 (which is posix) to extract the first 8 chars.
They don't have to be followed by anything.
|
@bors: r+ force p=10 |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit 08ba74d has been approved by |
|
⌛ Testing commit 08ba74d with merge ed7d3e4... |
the "-c" option of head isn't a posix option, and it isn't supported under openbsd. prefer the use of cut -c 1-8 (which is posix) to extract the first 8 chars. r? @alexcrichton
They don't have to be followed by anything.
fix a small typo in the official tutorial. "coerce" instead of "coerece" r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.