Rollup of 12 pull requests #25735
Merged
Rollup of 12 pull requests #25735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, when checking for common gendered words elsewhere, I found one 'he', moved to 'they' as well. rust-lang#25640 (comment)
Took me a moment to figure out that the appropriate response to "need program file" was to install the program named "file", not to think "If I didn't need the program file, why would I be compiling things?".
The `run` function passed its argument to `msg` via `"$@"`, but `msg` only printed its first argument. I think the intention was for `msg` to print all its arguments. (If not, `run` should only `msg "$1"`.)
There are more possible optimizations left (cached length in loops) as well as some possible bugs (shadowed variables) to fix. This is mostly syntactic.
I consider that this version has a better reading fluency, instead of having a period between clauses
Also, when checking for common gendered words elsewhere, I found one 'he', moved to 'they' as well. rust-lang#25640 (comment)
Cleanup extracted from rust-lang#25684. r? @alexcrichton
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
Reduces pre-trans heap baseline (tested on `fn main() {}`) from 1.2MB to 696kB.
Most of the remaining allocations are used by imported macros.
While it might be possible to also load macros lazily, doing so is non-trivial and this PR doesn't tackle that.
Sounds better to me this way. r @steveklabnik ?
…fackler fixes rust-lang#25683 I have a very nonscientific measurement of the data via valgrind/massif [here](https://gist.github.com/Manishearth/4c47f15f6835cb3957c4) I measured the memory usage for both --pretty=expanded and -Z no-trans It *seems* like there's a 20-25MB decrease during expansion on stage2 librustc; but I'm not quite sure. r? @eddyb (have not yet run tests, but it compiles fine, might want to wait before giving r+) cc @nrc @huon
I consider that this version has a better reading fluency, instead of having a period between clauses
…=brson Was able to successfully configure. Building and testing now.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10000000 |
|
📌 Commit a650075 has been approved by |
|
Didn't get time between travelling and talk-giving to rollup, thanks for filling in! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core::numusingSelf#25687, Document the debug_assertions cfg option #25695, Two minor friendliness patches to ./configure #25697, Rustdoc search: Increase relevance of primitive types #25702, Lazy-load filemaps from external crates. #25703, better describe the stdlib #25709, Let MultiItemDecorator take&Annotatable#25710, Make it clear that push is only amortized O(1) #25714, Update guessing-game.md #25715, Don't mention outdated methods #25716, allow clang 3.7 to be used when configuring Fixes #25720 #25722