-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add 5 more error explanations. Update E0015's explanation. Add an error code. #25873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also changes 'owned pointers' => 'boxes' in the error message.
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
I think it makes more sense to link to the text of the RFC rather than the PR. |
variant constructors or struct constructors (for unit or tuple structs). This | ||
is because Rust currently does not support compile-time function execution. | ||
The only function calls allowed in static or constant expressions are | ||
constructors for enum variants and structs, or `const fn`s. Rust currently does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that enum variants and tuple structs are function calls is just confusing here. Now const fn
is a thing, it's probably better to just say "only const fn
s can be called in static or constant expressions, since they obviously would have seen this error by using a non-const fn
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point.
@Aatch I agree, but I don't know of a way to wrap URLs in Markdown, and the lines have to be <= 80 chars. I can do this if I don't set the URL out separately, but generally this is less readable when printed out on the command line. For example, it would look like this:
Edit: Now that I think about it, I'm not sure that this works either. Github renders the URL here as |
Ahh, I didn't see that the url for the text of RFC 911 is actually short enough to link to here. I've changed that. RFC 246's url is still too long |
While I'd still prefer a link to the RFC text, I can see the issue. It's not too big of problem though. |
The E0397 explanation, as I've written it, isn't really an explanation, but I'm not sure what to put here. I will happily take suggestions. Partially addresses rust-lang#25851
The E0397 explanation, as I've written it, isn't really an explanation, but I'm not sure what to put here. I will happily take suggestions. Partially addresses rust-lang#25851
The E0397 explanation, as I've written it, isn't really an explanation, but I'm not sure what to put here. I will happily take suggestions.
Partially addresses #25851