Skip to content

Some 1.2 relnotes #26613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2015
Merged

Some 1.2 relnotes #26613

merged 2 commits into from
Jul 10, 2015

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 27, 2015

Haven't finished these, but since others are also working on this and I'm on vacation I figured I should get this in.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor Author

brson commented Jun 27, 2015

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Jun 27, 2015
alexcrichton
alexcrichton reviewed Jun 27, 2015
View reviewed changes
AUTHORS.txt
@@ -760,10 +813,13 @@ nsf <[email protected]>
nwin <[email protected]>
Oak <[email protected]>
OGINO Masanori <[email protected]>
OlegTsyba <[email protected]>
Oliver Schneider <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate for a mailmap entry?

@alexcrichton
Copy link
Member

Nice! r=me with a few nits

bluss
bluss reviewed Jun 27, 2015
View reviewed changes
RELEASES.md
for writing data to formatted strings, similar to [`io::Write`].
* [`fmt::Formatter`] adds 'debug builder' methods, [`debug_struct`],
[`debug_tuple`], [`debug_list`], [`debug_set`], [`debug_map`]. These
are used by code generators to emit implementations of [`Debug`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is the right place to mention {:#?} (pretty printing by using alternative format for Debug). It's hugely useful so we need to document it. It's a debug printer feature, only problem it was available already from Rust 1.1 in derived Debug impls.

@bluss
Copy link
Member

bluss commented Jun 27, 2015

I tagged PR #26058, so its entry could read

[Language]
* Patterns with `ref mut` now correctly invoke [`DerefMut`] when matching against dereferencable values.

[`DerefMut`]: http://doc.rust-lang.org/nightly/std/ops/trait.DerefMut.html

@bors
Copy link
Collaborator

bors commented Jun 27, 2015

☔ The latest upstream changes (presumably #26579) made this pull request unmergeable. Please resolve the merge conflicts.

arielb1
arielb1 reviewed Jun 27, 2015
View reviewed changes
.mailmap
@@ -13,7 +13,7 @@ Alex Rønne Petersen <[email protected]>
Andreas Gal <[email protected]> <[email protected]>
Andrew Poelstra <[email protected]> <[email protected]>
Anton Löfgren <[email protected]> <[email protected]>
Ariel Ben-Yehuda <[email protected]> <[email protected]>
Ariel Ben-Yehuda <[email protected]> arielb1 <[email protected]> <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to have my mail twice.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 1, 2015
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 7, 2015
@brson brson force-pushed the relnotes branch 5 times, most recently from 6337577 to 9cbef6c Compare July 9, 2015 22:36
@brson
Copy link
Contributor Author

brson commented Jul 9, 2015

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Jul 9, 2015

📌 Commit 0d60e8d has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

⌛ Testing commit 0d60e8d with merge fc03764...

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

💔 Test failed - auto-linux-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jul 9, 2015 at 5:44 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5664

—
Reply to this email directly or view it on GitHub
#26613 (comment).

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

⌛ Testing commit 0d60e8d with merge a5e0348...

@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

⌛ Testing commit 0d60e8d with merge 9cb1c29...

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jul 9, 2015 at 11:50 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5689

—
Reply to this email directly or view it on GitHub
#26613 (comment).

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

⌛ Testing commit 0d60e8d with merge 4695fbd...

bors added a commit that referenced this pull request Jul 10, 2015
@bors
Auto merge of #26613 - brson:relnotes, r=alexcrichton
4695fbd 
Haven't finished these, but since [others](#26579) are also working on this and I'm on vacation I figured I should get this in.
@bors
Copy link
Collaborator

bors commented Jul 10, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 0d60e8d into rust-lang:master Jul 10, 2015
@brson brson mentioned this pull request Jul 27, 2015
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@brson @rust-highfive @alexcrichton @bluss @bors @arielb1 @nikomatsakis @aturon