Skip to content

std: Fix formatting flags for chars #26698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2015
Merged

std: Fix formatting flags for chars #26698

merged 1 commit into from
Jul 1, 2015

Conversation

alexcrichton
Copy link
Member

This recently regressed in #24689, and this updates the Display implementation
to take formatting flags into account.

Closes #26625

@alexcrichton
std: Fix formatting flags for chars
98566ea 
This recently regressed in rust-lang#24689, and this updates the `Display` implementation
to take formatting flags into account.

Closes rust-lang#26625
@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Fix is by @SimonSapin

@alexcrichton
Copy link
Member Author

Nominating for backporting to beta as well (as this regression first appeared in beta)

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 1, 2015
@huonw
Copy link
Member

huonw commented Jul 1, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2015

📌 Commit 98566ea has been approved by huonw

bors added a commit that referenced this pull request Jul 1, 2015
@bors
Auto merge of #26698 - alexcrichton:char-fmt, r=huonw
1fc0f68 
This recently regressed in #24689, and this updates the `Display` implementation
to take formatting flags into account.

Closes #26625
@bors
Copy link
Collaborator

bors commented Jul 1, 2015

⌛ Testing commit 98566ea with merge 1fc0f68...

@bors
Copy link
Collaborator

bors commented Jul 1, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 98566ea into rust-lang:master Jul 1, 2015
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 7, 2015
@alexcrichton alexcrichton deleted the char-fmt branch July 8, 2015 20:36
@alexcrichton
Copy link
Member Author

accepting for beta

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 8, 2015
@alexcrichton alexcrichton mentioned this pull request Jul 8, 2015
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@huonw huonw

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @huonw @bors @brson