FFI panic is UB #26761
Merged
FFI panic is UB #26761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(lgtm but alex is the expert -- though I of course favour using Scare Caps for Undefined Behaviour) |
| @@ -544,8 +545,8 @@ pub extern fn oh_no() -> ! { | |||
| # fn main() {} | |||
| ``` | |||
|
|
|||
| If you’re writing code that may panic, you should run it in another thread, | |||
| so that the panic doesn’t bubble up to C: | |||
| But it could do anything. If you’re writing code that may panic, you should run | |||
There was a problem hiding this comment.
I find this kinda confusing that this starts out by saying that the code could abort but then follows it up by saying it could do anything instead. Overall there's not a great thing we can say here without a stable catch_panic. I think the core truth here is that unwinding just shouldn't cross FFI boundaries, and the way to do that is catch_panic, once stabilized.
|
@alexcrichton updated |
I incorrectly stated that it's an abort.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 7, 2015
…chton I incorrectly stated that it's an abort. r? @gankro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I incorrectly stated that it's an abort.
r? @gankro