-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Revert putting stage number in --version #26863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Oh, the effect of the reverted patches is that on Linux nightlies, the compiler reports |
Yeah, sorry about the confusion here (I realised that something was amiss in this comment: #26599 (comment)) it's extremely unclear what's happening, when I forced a stage3 build, it reports nothing, however my stage2 reports Apologies for the confusion, I'll try to work out what went sideways this week. |
⌛ Testing commit 147da94 with merge 50df2a0... |
This reverts #26599, which puts the stage number in the output of `--version -v`, but is not supposed to put it in the 'stage2' compiler, which is what most people refer to the binary we deploy. The picture is not so clear though because of how stage 'promotions' happen in the build and also because the windows build deploys stage3, not stage2. cc @richo
This reverts #26599, which puts the stage number in the output of
--version -v
, but is not supposed to put it in the 'stage2' compiler, which is what most people refer to the binary we deploy.The picture is not so clear though because of how stage 'promotions' happen in the build and also because the windows build deploys stage3, not stage2.
cc @richo