Fix doc comment parsing in macros. #27056
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This looks nice, but it'd be great to modify the rustdoc tests to test this case too (afaict, the tests in question don't actually test what the rustdoc output looks like, right?) |
|
The existing tests are in |
|
Yeah these tests are just for checking that inner/outer are expanded into the correct token trees, will try and decipher the rustdoc test syntax now. |
|
Ok added a rustdoc test, hopefully all is well as testing mostly involved inverting the logic and inserting deliberate typos (python errors are not as useful as rust errors!). |
|
☔ The latest upstream changes (presumably #27098) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ nice! |
|
📌 Commit a219917 has been approved by |
Fixes #23812 by stripping the decoration when desugaring macro doc comments into #[doc] attributes, and detects whether the attribute should be inner or outer style and outputs the appropriate token tree.
ghost
deleted the
Fixes #23812 by stripping the decoration when desugaring macro doc comments into #[doc] attributes, and detects whether the attribute should be inner or outer style and outputs the appropriate token tree.