Rollup of 5 pull requests #27270
Closed
Rollup of 5 pull requests #27270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the object trait matches the required trait during trait selection. The existing code was checking that the object trait WOULD match (in a probe), but never executing the match outside of a probe. This corrects various regressions observed in the wild, including issue rust-lang#26952. Fixes rust-lang#26952.
…labnik @steveklabnik had suggested I do this. This needs much review -- I tried reducing the informal tone but there's room for improvement. r? @steveklabnik
…abnik I'll be adding more commits to this PR as the weekend progresses. Was hoping to make this a mega-PR, but getting some eyes on this early would be nice too. r? @steveklabnik r? @eddyb on the object safety bits cc @michaelsproul Part of rust-lang#24407
Correct regression in type-inference caused by failing to reconfirm that the object trait matches the required trait during trait selection. The existing code was checking that the object trait WOULD match (in a probe), but never executing the match outside of a probe. This corrects various regressions observed in the wild, including issue rust-lang#26952. Fixes rust-lang#26952. r? @eddyb cc @frankmcsherry
…lexcrichton Fixes rust-lang#27263.
|
@bors r+ p=200 force |
|
📌 Commit 352ff41 has been approved by |
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 352ff41 with merge 6f85b6f... |
|
💔 Test failed - auto-mac-64-opt |
|
☔ The latest upstream changes (presumably #26960) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem::transmutewith more specific functions #27233, Correct regression in type-inference #27258, Fiximproper_ctypesfallout #27267