Skip to content

Change explicit BytesDeref impl into Cloned iterator #28119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2015

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Aug 31, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss
Copy link
Member

bluss commented Aug 31, 2015

Thinking about the parallel .count() etc change to Bytes, I'm not sure we should do this. Can we specialize .count() on Cloned to bypass cloning and ask the inner iterator? I don't think so — the difference is user observable.

@nagisa
Copy link
Member Author

nagisa commented Aug 31, 2015

@bluss #28125

@bluss
Copy link
Member

bluss commented Aug 31, 2015

Thanks for the pointer

@alexcrichton
Copy link
Member

@bors: r+ 25dce09

@bors
Copy link
Collaborator

bors commented Sep 1, 2015

⌛ Testing commit 25dce09 with merge 12067a4...

@bors
Copy link
Collaborator

bors commented Sep 1, 2015

💔 Test failed - auto-linux-32-nopt-t

@nagisa
Copy link
Member Author

nagisa commented Sep 3, 2015

I don’t have any idea why the test failed here.

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Sep 3, 2015 at 10:46 AM, Simonas Kazlauskas <
[email protected]> wrote:

I don’t have any idea why the test failed here.


Reply to this email directly or view it on GitHub
#28119 (comment).

@bors
Copy link
Collaborator

bors commented Sep 3, 2015

⌛ Testing commit 25dce09 with merge 922d247...

@bors
Copy link
Collaborator

bors commented Sep 3, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Sep 3, 2015

⌛ Testing commit 25dce09 with merge f54c3db...

bors added a commit that referenced this pull request Sep 3, 2015
@bors
Copy link
Collaborator

bors commented Sep 3, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Sep 4, 2015

⌛ Testing commit 25dce09 with merge 94ddfc7...

bors added a commit that referenced this pull request Sep 4, 2015
@bors bors merged commit 25dce09 into rust-lang:master Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants