Skip to content

Tracked down the thing that broke the pretty printer #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Tracked down the thing that broke the pretty printer #288

wants to merge 1 commit into from

Conversation

marijnh
Copy link
Contributor

@marijnh marijnh commented Mar 25, 2011

No description provided.

A change in 54587bd (the vec
appending overhaul) had broken it. (Apparently modifying a vec while
iterating over it can corrupt memory.)
@graydon
Copy link
Contributor

graydon commented Mar 25, 2011

Integrated.

@graydon graydon closed this Mar 25, 2011
oli-obk added a commit to oli-obk/rust that referenced this pull request Sep 19, 2017
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this pull request Dec 12, 2017
Adding sysinfo() and sysinfo struct for Linux and Android.

Sadly, the sysinfo struct varies slightly between Musl and Glibc / Bionic.

This means that users need to be careful when using the uptime, and should
always cast it to a signed value. Why uptime can be signed is beyond me...
carolynzech pushed a commit to carolynzech/rust that referenced this pull request Apr 17, 2025
…g#288)

This restores a fix from rust-lang#250 that was deemed no longer necessary with
the move to subtree split (in rust-lang#270), but this proved to be wrong. (See
model-checking@ab648fe
for such an example of an unintended change.)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

Co-authored-by: thanhnguyen-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants