Issue 28157 bad semicolon #29215
Merged
Issue 28157 bad semicolon #29215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
fhahn
force-pushed
the
issue-28157-bad-semicolon
branch
from
5c9d218 to
ca784f3
Compare
|
As a language change, I think that this may want some more visibility before moving forward. I would personally consider 28157 as "wontfix", but I'm sure others will have opinions as well! |
fhahn
force-pushed
the
issue-28157-bad-semicolon
branch
2 times, most recently
from
4f1f989 to
bcd4400
Compare
fhahn
force-pushed
the
issue-28157-bad-semicolon
branch
from
bcd4400 to
107b4aa
Compare
|
I've updated the PR to just include the commit that removes a few bare semicolons. I did not end up removing semicolons from macros. |
bors
added a commit
that referenced
this pull request
Oct 24, 2015
PR for #28157. At the moment, `rustc` emits a warning when a bare semicolon is encountered (could also be a fail, but I think this is a backwards incompatible change). Also I am not sure where the best place for a test for that warning would be. Seems run-pass tests do not check warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #28157. At the moment,
rustcemits a warning when a bare semicolon is encountered (could also be a fail, but I think this is a backwards incompatible change).Also I am not sure where the best place for a test for that warning would be. Seems run-pass tests do not check warnings.