Skip to content

mk: Package libstdc++-6.dll on x86_64 MinGW #29306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2015
Merged

mk: Package libstdc++-6.dll on x86_64 MinGW #29306

merged 1 commit into from
Oct 26, 2015

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 25, 2015

We don't need the support libgcc SEH library, but we do need the C++ standard
library for running the compiler itself.

cc #29208
Closes #29294

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 25, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton mentioned this pull request Oct 25, 2015
Closed
@alexcrichton
mk: Package libstdc++-6.dll on x86_64 MinGW
d51b432 
We don't need the support libgcc SEH library, but we do need the C++ standard
library for running the compiler itself.

cc rust-lang#29208
@alexcrichton alexcrichton force-pushed the yet-another-windows-dist-fix branch from b100bb7 to d51b432 Compare October 25, 2015 17:32
@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 25, 2015

r? @vadimcn

@alexcrichton alexcrichton mentioned this pull request Oct 25, 2015
Closed
@vadimcn
Copy link
Contributor

vadimcn commented Oct 25, 2015

@bors: r+ d51b432

@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 26, 2015

@bors: p=1

bors added a commit that referenced this pull request Oct 26, 2015
@bors
Auto merge of #29306 - alexcrichton:yet-another-windows-dist-fix, r=v…
039b2ca 
…adimcn

We don't need the support libgcc SEH library, but we do need the C++ standard
library for running the compiler itself.

cc #29208
Closes #29294
@bors
Copy link
Collaborator

bors commented Oct 26, 2015

⌛ Testing commit d51b432 with merge 039b2ca...

@bors
Copy link
Collaborator

bors commented Oct 26, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit d51b432 into rust-lang:master Oct 26, 2015
@Diggsey
Copy link
Contributor

Diggsey commented Oct 27, 2015

The libgcc SEH library is still required on 64-bit windows-gnu!

@alexcrichton alexcrichton deleted the yet-another-windows-dist-fix branch October 27, 2015 16:33
@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 27, 2015

Ugh forgot that although we don't depend on it libstdc++ does...

@alexcrichton alexcrichton mentioned this pull request Oct 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexcrichton @rust-highfive @vadimcn @bors @Diggsey @brson