Fix makefile rules for generated llvmdeps.rs file #29397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the file was not regenrated upon modification of src/rustllvm or others. Now it will be rebuilt if `src/llvm` or `src/rustllvm` is touched. Also added *.rs rule to 'clean' rule so that it is removed upon 'make clean'.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Why should it be regenerated when |
|
This script doesn't actually look at the LLVM source, so I don't think adding those targets as dependencies would fix the issue here, but the fix to |
|
@bors r+ rollup |
|
📌 Commit 9c1dad7 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 24, 2015
Previously the file was not regenrated upon modification of `src/rustllvm` or others. Now it will be rebuilt if `src/llvm` or `src/rustllvm` is touched. Also added *.rs rule to 'clean' rule so that it is removed upon 'make clean'. Fixes rust-lang#28614.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 24, 2015
Previously the file was not regenrated upon modification of `src/rustllvm` or others. Now it will be rebuilt if `src/llvm` or `src/rustllvm` is touched. Also added *.rs rule to 'clean' rule so that it is removed upon 'make clean'. Fixes rust-lang#28614.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the file was not regenrated upon modification of
src/rustllvmor others.Now it will be rebuilt if
src/llvmorsrc/rustllvmis touched.Also added *.rs rule to 'clean' rule so that it is removed upon 'make
clean'.
Fixes #28614.