Added try! example to documentation.md #29234 #29420
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! Remember to close #29234 after this is merged. 😄 (Or add |
| Another case where the use of `#` is handy is when you want to ignore | ||
| error handling. Lets say you want the following, | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
this should be ignored, so that it doesn't fail
|
This looks good! Yes, if you could fix that failure by marking that first block as ignore, and while you're at it, fix up that commit message, r=me after :) |
| /// # } | ||
| /// # f(); | ||
| /// ``` | ||
| ``` |
There was a problem hiding this comment.
Ah! Another issue. So, you actually need something after a documentation comment for this to parse, so add something like
# fn foo() { }
Does that make sense? That's why the build is failing. I think there's an example in this file...
|
@bors: r+ rollup |
|
📌 Commit dda7a3c has been approved by |
|
@EFindlay sorry about that! you have to actually leave a comment when you push, github won't send a notification :/ |
r? @steveklabnik