Skip to content

docs: split a run-on sentence #29442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2015
Merged

docs: split a run-on sentence #29442

merged 1 commit into from
Oct 29, 2015

Conversation

rjbs
Copy link
Contributor

@rjbs rjbs commented Oct 28, 2015

This is two sentences that have been comma spliced, and should
be split with a full stop. (This error made me stop and re-read,
and I submit this as an actual improvement to readability, not
as a grammar weird-o!)

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1 +1 @@
Subproject commit 96626ab9c1242b42a60df9b3cd9a0dc8920b5ea6
Subproject commit 58ab642c30d9f97735d5745b5d01781ee199c6ae
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistake!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, I have no idea how that happened. Sorry, I'll be more careful in the future, and will fix this right now…

This is two sentences that have been comma spliced, and should
be split with a full stop.  (This error made me stop and re-read,
and I submit this as an actual improvement to readability, not
as a grammar weird-o!)
@rjbs rjbs force-pushed the docs-comma-splice branch from 16028e3 to 618d226 Compare October 29, 2015 00:56
@rjbs
Copy link
Contributor Author

rjbs commented Oct 29, 2015

I've removed a mistaken commit to a submodule, leaving only the intended change.

@steveklabnik
Copy link
Member

it's all good, it happens all the time. Thanks again for the patch!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 29, 2015

📌 Commit 618d226 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Oct 29, 2015

⌛ Testing commit 618d226 with merge 696cd7c...

bors added a commit that referenced this pull request Oct 29, 2015
This is two sentences that have been comma spliced, and should
be split with a full stop.  (This error made me stop and re-read,
and I submit this as an actual improvement to readability, not
as a grammar weird-o!)
@bors bors merged commit 618d226 into rust-lang:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants