Skip to content

Add TRACE to the known log levels #30012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Add TRACE to the known log levels #30012

merged 1 commit into from
Nov 24, 2015

Conversation

jonas-schievink
Copy link
Contributor

The log crate on crates.io already knows TRACE, but the internal liblog doesn't, which causes it to spew errors when a TRACE level is defined. I made TRACE behave like DEBUG.

The `log` crate on crates.io already knows TRACE, but the internal
liblog doesn't, which causes it to spew errors when a TRACE level is
defined.
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 3f36ce8

In general I don't want to put too much effort behind maintaining these in-tree copies of libraries as the out-of-tree ones continue to evolve, but this is pretty harmless and seems like a nice win!

bors added a commit that referenced this pull request Nov 24, 2015
The `log` crate on crates.io already knows `TRACE`, but the internal liblog doesn't, which causes it to spew errors when a `TRACE` level is defined. I made `TRACE` behave like `DEBUG`.
@bors
Copy link
Collaborator

bors commented Nov 24, 2015

⌛ Testing commit 3f36ce8 with merge 9cf0e3c...

@bors bors merged commit 3f36ce8 into rust-lang:master Nov 24, 2015
@jonas-schievink jonas-schievink deleted the log-level-trace branch December 26, 2015 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants