Document the Error types in std::string #30124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -36,7 +36,41 @@ pub struct String { | |||
| vec: Vec<u8>, | |||
| } | |||
|
|
|||
| /// A possible error value from the `String::from_utf8` function. | |||
| /// A possible error value when converting a `String` from a UTF8 byte vector. | |||
steveklabnik
force-pushed
the
doc_string_errors
branch
from
f74c6a8 to
674c39e
Compare
| @@ -337,8 +390,8 @@ impl String { | |||
| /// | |||
| /// ``` | |||
| /// // 𝄞music | |||
| /// let mut v = &mut [0xD834, 0xDD1E, 0x006d, 0x0075, | |||
| /// 0x0073, 0x0069, 0x0063]; | |||
| /// let v = &mut [0xD834, 0xDD1E, 0x006d, 0x0075, | |||
There was a problem hiding this comment.
I think in these examples the mut here can be dropped as well (may have just bee included by accident long ago)
steveklabnik
force-pushed
the
doc_string_errors
branch
from
674c39e to
8f6b30e
Compare
|
@bors: r+ 8f6b30ea455d41660a544876069a1fdae9ce8f45 |
|
⌛ Testing commit 8f6b30e with merge 0cf64b8... |
|
💔 Test failed - auto-mac-64-nopt-t |
steveklabnik
force-pushed
the
doc_string_errors
branch
from
8f6b30e to
546e8f9
Compare
|
@bors: r=alexcrichton |
|
📌 Commit 546e8f9 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29376