Skip to content

MIN_ALIGN is definitely 8 on 32-bit x86, at least on Windows. #30183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

retep998
Copy link
Member

@retep998 retep998 commented Dec 3, 2015

This fixes it so the Rust allocator on Windows 32-bit doesn't think the system allocator is aligned to 16 when it is really only aligned to 8.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member

pnkfelix commented Dec 3, 2015

Hmm, is this too broad, or is it perfect ? ... we may want to double-check against some other targets.

(The reason i say it might be "perfect" is that, if i understand correctly, this can at the very worst just cause some code to get slower ... it shouldn't inject any unsoundness... so it may be fine to just take the patch...)

@alexcrichton
Copy link
Member

https://msdn.microsoft.com/en-us/library/ycsb6wwf.aspx seems to agree, and otherwise I agree that this probably won't harm code, just perhaps make it a tad slower in some niche situations (it's pretty rare to ask for > 8 alignment anyway).

@bors: r+ 098f4fb

@bors
Copy link
Collaborator

bors commented Dec 4, 2015

⌛ Testing commit 098f4fb with merge 5854fed...

bors added a commit that referenced this pull request Dec 4, 2015
This fixes it so the Rust allocator on Windows 32-bit doesn't think the system allocator is aligned to 16 when it is really only aligned to 8.
@bors bors merged commit 098f4fb into rust-lang:master Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants