Skip to content

is_empty for OsStr #30623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

is_empty for OsStr #30623

wants to merge 4 commits into from

Conversation

ticki
Copy link
Contributor

@ticki ticki commented Dec 29, 2015

Part of #30520

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ticki
Copy link
Contributor Author

ticki commented Dec 29, 2015

fixes #30259

@ticki
Copy link
Contributor Author

ticki commented Jan 1, 2016

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned nikomatsakis Jan 1, 2016
@Gankra
Copy link
Contributor

Gankra commented Jan 2, 2016

Travis seems unhappy

@ticki
Copy link
Contributor Author

ticki commented Jan 2, 2016

It compiles on my machine, and the tests runs fine. I don't understand why travis is sad. I'm also unable to find travis's complains in the travis log.

@Gankra
Copy link
Contributor

Gankra commented Jan 3, 2016


failures:

---- path::Path::is_empty_0 stdout ----
    <anon>:8:19: 8:29 error: use of unstable library feature 'os_extras': recently added (see issue #30259)
<anon>:8     assert!(!path.is_empty());
                           ^~~~~~~~~~
<anon>:8:5: 8:31 note: in this expansion of assert! (defined in <std macros>)
<anon>:8:19: 8:29 help: add #![feature(os_extras)] to the crate attributes to enable
error: aborting due to previous error
thread 'path::Path::is_empty_0' panicked at 'Box<Any>', src/libsyntax/errors/mod.rs:269


failures:
    path::Path::is_empty_0

test result: �[31mFAILED�(B�[0m. 443 passed; 1 failed; 11 ignored; 0 measured

///
/// # Examples
///
/// ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a #![feature(os_extras)] here in this code block

@alexcrichton
Copy link
Member

Closing due to inactivity, but feel free to resubmit with tests passing!

@frewsxcv
Copy link
Member

Rebased this and fixed in #31231

frewsxcv pushed a commit to frewsxcv/rust that referenced this pull request Jan 27, 2016
@ticki
Copy link
Contributor Author

ticki commented Feb 13, 2016

Thanks @frewsxcv!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 25, 2016
Original issue requesting this feature:
rust-lang#30259

Originally implemented in rust-lang#30623
but that pull request when stale.

It was rebased in rust-lang#31231, but the
`Path` changes got lost as the focus shifted towards `OsString` and
`OsStr`.

An RFC (rust-lang/rfcs#1497) was briefly
opened, since I didn't know if this functionality needed an RFC, but
@alexcrichton clarified in the RFC issue I linked that this is not the
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants