-
Notifications
You must be signed in to change notification settings - Fork 13.3k
is_empty for OsStr #30623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_empty for OsStr #30623
Conversation
…ough the unicode validity checking on Windows Add issue to attr
Added features
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
fixes #30259 |
r? @gankro |
Travis seems unhappy |
It compiles on my machine, and the tests runs fine. I don't understand why travis is sad. I'm also unable to find travis's complains in the travis log. |
|
/// | ||
/// # Examples | ||
/// | ||
/// ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a #![feature(os_extras)]
here in this code block
Closing due to inactivity, but feel free to resubmit with tests passing! |
Rebased this and fixed in #31231 |
Related to rust-lang#30259 Rebase of rust-lang#30623
Thanks @frewsxcv! |
Original issue requesting this feature: rust-lang#30259 Originally implemented in rust-lang#30623 but that pull request when stale. It was rebased in rust-lang#31231, but the `Path` changes got lost as the focus shifted towards `OsString` and `OsStr`. An RFC (rust-lang/rfcs#1497) was briefly opened, since I didn't know if this functionality needed an RFC, but @alexcrichton clarified in the RFC issue I linked that this is not the case.
Part of #30520