Add mention of warnings lint group to help message #30728
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -632,6 +633,8 @@ Available lint options: | |||
| .map(|&(s, _)| s.chars().count()) | |||
| .max() | |||
| .unwrap_or(0); | |||
| let max_name_len = std::cmp::max(max_name_len, "warnings".len()); | |||
There was a problem hiding this comment.
Just max here since you imported it.
There was a problem hiding this comment.
Oh, okay! I should review how importing modules works. I had tried cmp::max and that gave me a compiler error, but std::cmp::max compiled so I went with that.
|
@bors r+ Thanks! |
|
📌 Commit 5038d4e has been approved by |
…arth Fixes #30203. This is my first time writing Rust, and I think this code could be a bit better. Any suggestions?
Fixes #30203.
This is my first time writing Rust, and I think this code could be a bit better. Any suggestions?