Skip to content

Fixes #30873 #30874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2016
Merged

Fixes #30873 #30874

merged 2 commits into from
Jan 14, 2016

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Jan 13, 2016

fixes the failing bitrig unit tests.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@dhuseby
Copy link
Author

dhuseby commented Jan 13, 2016

@brson the change in file src/libstd/lib.rs fixes deprecation warnings on all of the bsd platforms. I'm pretty sure that the dynamic_lib module is only used on Linux and Windows, but please double check me on that. Thanks!

@alexcrichton
Copy link
Member

dynamic_lib is actually required on all platforms for the compiler as it's how we load plugins currently, so perhaps that could stick around?

@dhuseby
Copy link
Author

dhuseby commented Jan 13, 2016

@alexcrichton ah, i see this:

librustc_plugin/lib.rs:61:#![feature(dynamic_lib)]
librustc_plugin/load.rs:111:        use std::dynamic_lib::DynamicLibrary;
librustdoc/lib.rs:22:#![feature(dynamic_lib)]
librustdoc/plugins.rs:15:use std::dynamic_lib as dl;
librustdoc/test.rs:15:use std::dynamic_lib::DynamicLibrary;

is this what you're talking about?

@dhuseby
Copy link
Author

dhuseby commented Jan 13, 2016

let me remove that part from the patch.

@dhuseby
Copy link
Author

dhuseby commented Jan 13, 2016

@alexcrichton alright, i removed the conditional compile.

@alexcrichton
Copy link
Member

@bors: r+ 5ecccb1 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 14, 2016
…crichton

fixes the failing bitrig unit tests.
bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit 5ecccb1 into rust-lang:master Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants