Skip to content

Allow #[repr(i32)] for univariant enum #31232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/librustc_typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4250,14 +4250,9 @@ pub fn check_enum_variants<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>,
let def_id = ccx.tcx.map.local_def_id(id);
let hint = *ccx.tcx.lookup_repr_hints(def_id).get(0).unwrap_or(&attr::ReprAny);

if hint != attr::ReprAny && vs.len() <= 1 {
if vs.len() == 1 {
span_err!(ccx.tcx.sess, sp, E0083,
"unsupported representation for univariant enum");
} else {
span_err!(ccx.tcx.sess, sp, E0084,
"unsupported representation for zero-variant enum");
};
if hint != attr::ReprAny && vs.is_empty() {
span_err!(ccx.tcx.sess, sp, E0084,
"unsupported representation for zero-variant enum");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove E0083 along with this change

}

do_check(ccx, vs, id, hint);
Expand Down
7 changes: 0 additions & 7 deletions src/librustc_typeck/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1062,13 +1062,6 @@ Note also that without a representation manually defined, the compiler will
optimize by using the smallest integer type possible.
"##,

E0083: r##"
At present, it's not possible to define a custom representation for an enum with
a single variant. As a workaround you can add a `Dummy` variant.

See: https://github.com/rust-lang/rust/issues/10292
"##,

E0084: r##"
It is impossible to define an integer type to be used to represent zero-variant
enum values because there are no zero-variant enum values. There is no way to
Expand Down
47 changes: 47 additions & 0 deletions src/test/run-pass/enum-univariant-repr.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.


use std::mem;

// Univariant C-like enum
#[repr(i32)]
enum Univariant {
X = 17
}

#[repr(u16)]
enum UnivariantWithoutDescr {
Y
}

pub fn main() {
{
assert_eq!(4, mem::size_of::<Univariant>());
assert_eq!(17, Univariant::X as i32);

let enums: &[Univariant] =
&[Univariant::X, Univariant::X, Univariant::X];
let ints: &[i32] = unsafe { mem::transmute(enums) };
// check it has the same memory layout as i32
assert_eq!(&[17, 17, 17], ints);
}

{
assert_eq!(2, mem::size_of::<UnivariantWithoutDescr>());
let descr = UnivariantWithoutDescr::Y as u16;

let enums: &[UnivariantWithoutDescr] =
&[UnivariantWithoutDescr::Y, UnivariantWithoutDescr::Y, UnivariantWithoutDescr::Y];
let ints: &[u16] = unsafe { mem::transmute(enums) };
// check it has the same memory layout as u16
assert_eq!(&[descr, descr, descr], ints);
}
}