Rollup of 7 pull requests #31285
Merged
Rollup of 7 pull requests #31285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Jan 29, 2016
Manishearth
commented
- Successful merges: mk: Remove the -mfpu=vfp4 argument from arm iOS #31252, don't leak environment variables into test process #31256, Fix reference info about parent doc block comments #31264, rustdoc: Add missing trailing comma for single element tuples #31269, std::string::String.from_utf16 doc fix #31272, std: Fix rumprun build #31275, mk: Fix cross prefix for powerpc64 #31276
- Failed merges:
Unfortunately older clang compilers don't support this argument, so the bootstrap will fail. We don't actually really need to optimized the C code we compile, however, as currently we're just compiling jemalloc and not much else.
Block comments don't have to be in the format `/*! ... !*/` in order to be read as doc comments about the parent block. The format `/*! ... */` is enough.
Looks like the rumprun build has bitrotted over time, so this includes some libc fixes and some various libstd fixes which gets it back to bootstrapping.
Looks like the way to create these executables is to use the standard `powerpc-linux-gnu-gcc` compiler but with the `-m64` option.
If the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without it it succeeded. We need to use `env_remove` instead of `env_clear` because the latter will never work on windows
Unfortunately older clang compilers don't support this argument, so the bootstrap will fail. We don't actually really need to optimized the C code we compile, however, as currently we're just compiling jemalloc and not much else.
if the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without `RUST_BACKTRACE=1` it succeeded.
…ichton Block comments don't have to be in the format `/*! ... !*/` in order to be read as doc comments about the parent block. The format `/*! ... */` is enough.
Looks like the rumprun build has bitrotted over time, so this includes some libc fixes and some various libstd fixes which gets it back to bootstrapping.
…efix, r=brson Looks like the way to create these executables is to use the standard `powerpc-linux-gnu-gcc` compiler but with the `-m64` option.
|
@bors r+ p=10 |
|
📌 Commit 7a0e490 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Jan 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.