don't ICE on a couple of missing lang items #31564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 433f347 has been approved by |
|
⌛ Testing commit 433f347 with merge 1ab22d7... |
bors
added a commit
that referenced
this pull request
Feb 13, 2016
This changes three ICEs to fatal errors. I've grepped for `lang_item.*expect` and `\.expect.*lang` and didn't come up with any more. But, there could be more ICEs lurking. I wasn't sure about a test because there already _is_ a cfail test for missing lang items, but it only checks one. Relevant to (already closed) #31477 #31480 #31558. cc @LilRed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes three ICEs to fatal errors.
I've grepped for
lang_item.*expectand\.expect.*langand didn't come up with any more. But, there could be more ICEs lurking.I wasn't sure about a test because there already is a cfail test for missing lang items, but it only checks one.
Relevant to (already closed) #31477 #31480 #31558.
cc @LilRed