Skip to content

Fix regression in resolve #31566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Fix regression in resolve #31566

merged 1 commit into from
Feb 15, 2016

Conversation

jseyfried
Copy link
Contributor

This fixes a regression caused by #31461 allowing extern crates to be glob imported, and it fixes the test that was supposed to catch it.
r? @nrc

@jseyfried
Copy link
Contributor Author

When writing #31461, it slipped my mind that #31362 is not yet merged and glob imports still have to specifically disallow extern crates.

@jseyfried
Copy link
Contributor Author

@nrc This regression causes at least 18 crates to break (all the fixed crates in the crater run linked in #31362). I think we should merge this PR (or #31362) ASAP.

@nrc
Copy link
Member

nrc commented Feb 14, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 14, 2016

📌 Commit 9189463 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Feb 15, 2016

⌛ Testing commit 9189463 with merge 4e9cc69...

@bors
Copy link
Collaborator

bors commented Feb 15, 2016

💔 Test failed - auto-win-gnu-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Feb 14, 2016 at 6:47 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/3097


Reply to this email directly or view it on GitHub
#31566 (comment).

@bors
Copy link
Collaborator

bors commented Feb 15, 2016

⌛ Testing commit 9189463 with merge 69ad912...

bors added a commit that referenced this pull request Feb 15, 2016
This fixes a regression caused by #31461 allowing extern crates to be glob imported, and it fixes the test that was supposed to catch it.
r? @nrc
@bors bors merged commit 9189463 into rust-lang:master Feb 15, 2016
@jseyfried jseyfried deleted the fix_regression branch February 15, 2016 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants