Skip to content

pass CXX to run-make #31672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2016
Merged

pass CXX to run-make #31672

merged 1 commit into from
Feb 16, 2016

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Feb 15, 2016

use CXX value found at configure time inside run-make tests.

it permits OpenBSD to pass llvm-module-pass test (which use CXX
variable).

r? @alexcrichton

@sanxiyn
Copy link
Member

sanxiyn commented Feb 15, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 15, 2016

📌 Commit c4b8a50 has been approved by sanxiyn

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2016
use CXX value found at configure time inside run-make tests.

it permits OpenBSD to pass llvm-module-pass test (which use CXX
variable).

r? @alexcrichton
@Manishearth
Copy link
Member

This may have cause the failure here

use CXX value found at configure time inside run-make tests.

it permits OpenBSD to pass llvm-module-pass test (which use CXX
variable).
@semarie
Copy link
Contributor Author

semarie commented Feb 16, 2016

I have amended and repushed the patch in order to deal with windows. The buildhost use double-quote in CXX ("C:\Program Files (x86)\Microsoft Visual Studio 12.0/VC/bin/amd64/cl.exe" -nologo) and that escapes the ones added around it in tests.mk. So I use single-quote, like for CC.

@alexcrichton
Copy link
Member

@bors: r+ 263de3d

oh my god I hate shell

@bors
Copy link
Collaborator

bors commented Feb 16, 2016

⌛ Testing commit 263de3d with merge 8018280...

bors added a commit that referenced this pull request Feb 16, 2016
use CXX value found at configure time inside run-make tests.

it permits OpenBSD to pass llvm-module-pass test (which use CXX
variable).

r? @alexcrichton
1 similar comment
@bors bors merged commit 263de3d into rust-lang:master Feb 16, 2016
@semarie semarie deleted the rmake-cxx branch February 17, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants