Skip to content

Allow multiple libraries with the same hash. #32275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow multiple libraries with the same hash. #32275

wants to merge 1 commit into from

Conversation

taralx
Copy link
Contributor

@taralx taralx commented Mar 16, 2016

Removes the need for canonicalization to prevent #12459.

Removes the need for canonicalization to prevent #12459.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@retep998
Copy link
Member

If we just want to know whether two files with the same name are actually the same file, I know there is a way on Windows to just check the IDs of files to see if they're the same (and it works with hard links too). Either GetFileInformationByHandle which returns a 64-bit ID + 32-bit volume ID which is unique on everything except ReFS which is for newer Windows only where you'd have to call GetFileInformationByHandleEx to get a FILE_ID_INFO with a 128-bit ID + 64-bit volume ID. Unsure about other platforms though, but if they can do this too then there is no need to canonicalize or to allow duplicate files.

@taralx
Copy link
Contributor Author

taralx commented Mar 16, 2016

There's no need to know if two files are the same file. If they have the same hash in the filename, we can reasonably assume they are the same.

@taralx
Copy link
Contributor Author

taralx commented Mar 17, 2016

Ah, I see the problem. Is it okay if I just rework the patch, or would you prefer I stack on top?

@taralx
Copy link
Contributor Author

taralx commented Mar 17, 2016

sigh This gets complicated again. I'll resubmit after I work this one out.

@taralx taralx closed this Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants