Update of the book; Error handling, section on custom error types: we… #32340
Conversation
… should also show the changes to the `cause` method.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup thank you! |
|
📌 Commit 8f99ad2 has been approved by |
Update of the book; Error handling, section on custom error types: we… … should also show the changes to the `cause` method. When I started creating my own error type, I found that we also have to update the cause method, otherwise we have a missing match branch. It would also be nice to elaborate on the relationship and difference between the description() and fmt() method, but that should be done by someone with more experience with them. :)
|
Thank you for accepting my submission. :) So should I be closing the pull request from my side? What is the next step? |
|
@Digipom sorry it took me some time to get back to you. Once someone says So, pretty much you don't have to do anything once the Does that make sense? |
|
Yes it makes perfect sense, thanks for clarifying! I'm getting used to the way this all works. :) |
… should also show the changes to the
causemethod.When I started creating my own error type, I found that we also have to update the cause method, otherwise we have a missing match branch.
It would also be nice to elaborate on the relationship and difference between the description() and fmt() method, but that should be done by someone with more experience with them. :)