Skip to content

Reword explanation of 'size' types. #32906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2016
Merged

Reword explanation of 'size' types. #32906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46885ee
Reword explanation of 'size' types.
jocki84 Jan 30, 2016
069b3a6
Update primitive-types.md
jocki84 Apr 12, 2016
a548d4d
Update primitive-types.md
jocki84 Apr 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/doc/book/primitive-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,10 @@ and `i64` is a signed, 64-bit integer.

## Variable sized types

Rust also provides types whose size depends on the size of a pointer of the
underlying machine. These types have ‘size’ as the category, and come in signed
and unsigned varieties. This makes for two types: `isize` and `usize`.
Rust also provides types whose particular size depends on the underlying machine
architecture. Their range is sufficient to express the size of any collection, so
these types have ‘size’ as the category. They come in signed and unsigned varieties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find your last sentence a bit heavy. :-/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the sentence »Their range…« or »They come…«? Do you feel »account for« would be more idiomatic than »make for«?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking about "They come". "account for" sounds better from my point of view. :)

which account for two types: `isize` and `usize`.

## Floating-point types

Expand Down