Skip to content

Make going from &mut RefCell<T> to &mut T a no-op #33427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make going from &mut RefCell<T> to &mut T a no-op #33427

wants to merge 1 commit into from
+1 −1

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented May 5, 2016

No description provided.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-
Copy link
Contributor Author

tbu- commented May 5, 2016

This allows #32565 to make get_mut a no-op.

@huonw
Copy link
Member

huonw commented May 5, 2016

I suspect this will mean that T can't be an unsized type, or, at least, it seems it would be tempting bugs (last time I checked, field offsets didn't interact well with unsized types).

@tbu-
Copy link
Contributor Author

tbu- commented May 5, 2016

You're right, I forgot about unsized types.

@tbu- tbu- closed this May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbu- @rust-highfive @huonw @brson