More robust metadata lock - beta edition #34604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
r? @brson |
arielb1
force-pushed
the
metadata-hash-beta
branch
2 times, most recently
from
8fd4e34 to
e324784
Compare
|
Awesome fixes. Thanks @arielb1. I'm happy to backport. You @alexcrichton ? |
|
I'm good backporting as well, @arielb1 can you ping once tests pass locally? |
arielb1
force-pushed
the
metadata-hash-beta
branch
from
e324784 to
50870c9
Compare
…sion check the metadata lock when loading rather than afterwards Fixes rust-lang#33733 Fixes rust-lang#33015
previously, only .so files included a metadata encoding version, *outside* of the zlib compressed area. This adds an encoding version inside the metadata itself, in both .so and .rlib files. Fixes rust-lang#33778.
arielb1
force-pushed
the
metadata-hash-beta
branch
from
50870c9 to
8da25e8
Compare
|
Passes |
alexcrichton
added
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the metadata lock when loading rather than afterwards
Fixes #33778
Fixes #33733
Fixes #33015
This is the beta cherry-pick of #34539, without some unnecessary refactoring.