Use lazy iterator in vec/slice gdb pretty printers by dzamlo · Pull Request #34639 · rust-lang/rust

dzamlo · 2016-07-04T02:16:13Z

No description provided.

rust-highfive · 2016-07-04T02:16:21Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

michaelwoerister · 2016-07-04T15:17:48Z

src/test/debuginfo/pretty-huge-vec.rs

Can you elaborate on what that means?

I used the same ignore-* lines as the pretty-std.rs test, because the tests I added test a similar part of the code.

That's OK then.

michaelwoerister · 2016-07-04T16:11:06Z

Thanks a lot for the PR! If you take care of the nits I pointed out, I'd be happy to have it merged.

dzamlo · 2016-07-04T17:01:29Z

Should I make a second commit with the changes or do you prefer that I squash the requested changes with the existing commit?

srinivasreddy · 2016-07-04T17:15:04Z

I would generally, squash them. But either of it is okay, i guess.

michaelwoerister · 2016-07-04T18:13:56Z

Should I make a second commit with the changes or do you prefer that I squash the requested changes with the existing commit?

Please just squash them or use git commit --amend.

dzamlo · 2016-07-04T20:37:47Z

I think the nits have been taken care of.

michaelwoerister · 2016-07-04T21:17:15Z

Excellent! Thanks a lot!

michaelwoerister · 2016-07-04T21:17:23Z

@bors r+

bors · 2016-07-04T21:17:25Z

📌 Commit 5de76af has been approved by michaelwoerister

bors · 2016-07-04T22:09:36Z

⌛ Testing commit 5de76af with merge d7ef1ac...

Use lazy iterator in vec/slice gdb pretty printers

bors · 2016-07-05T00:59:12Z

alexcrichton · 2016-07-05T15:01:56Z

Hm so on the Linux bots (where these tests passed) the GDB we're running is:

GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.2) 7.7.1

whereas on the nightly bots (slightly different due to build funkiness) the GDB is custom-built and is:

GNU gdb (GDB) 7.11

Unfortunately the test added here is failing on the nightly bot (full logs):


failures:

---- [debuginfo-gdb] debuginfo-gdb/pretty-huge-vec.rs stdout ----
    NOTE: compiletest thinks it is using GDB version 7.11

error: line not found in debugger output: $1 = Vec<u8>(len: 1000000000, cap: 1000000000) = {[...]...}
status: exit code: 0
command: gdb -quiet -batch -nx -command=x86_64-unknown-linux-gnu/test/debuginfo-gdb/pretty-huge-vec.debugger.script
stdout:
------------------------------------------
GNU gdb (GDB) 7.11
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0xcac: file /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/tmp/distcheck/rustc-nightly/src/test/debuginfo/pretty-huge-vec.rs, line 38.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Breakpoint 1, pretty_huge_vec::main () at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/tmp/distcheck/rustc-nightly/src/test/debuginfo/pretty-huge-vec.rs:38
38      zzz(); // #break
$1 = Vec<u8>(len: 1000000000, cap: 1000000000)
$2 = &[u8](len: 1000000000)
A debugging session is active.

    Inferior 1 [process 25786] will be killed.

Quit anyway? (y or n) [answered Y; input not from terminal]

------------------------------------------
stderr:
------------------------------------------
Python Exception <type 'exceptions.MemoryError'> : 
Python Exception <type 'exceptions.MemoryError'> : 

------------------------------------------

thread '[debuginfo-gdb] debuginfo-gdb/pretty-huge-vec.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/tmp/distcheck/rustc-nightly/src/tools/compiletest/src/runtest.rs:2243
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [debuginfo-gdb] debuginfo-gdb/pretty-huge-vec.rs

test result: FAILED. 100 passed; 1 failed; 3 ignored; 0 measured

Maybe this fix only applies to older GDB versions? Maybe we need to recompile gdb somewhat differently than what we do today?

This ignores a test added in rust-lang#34639 because unfortunately the nightly bots are now broken, but this is now tracked in rust-lang#34662.

test: Ignore pretty-huge-vec.rs to fix nightlies This ignores a test added in #34639 because unfortunately the nightly bots are now broken, but this is now tracked in #34662.

bruno-medeiros · 2016-07-07T15:24:32Z

Sweet. Which Rust release version can we expect this fix to go into?

steveklabnik · 2016-07-07T15:51:37Z

@bruno-medeiros it landed just before the branch to beta, so I believe this will land in Rust 1.11, six weeks from today.

bruno-medeiros · 2016-07-29T14:55:50Z

@bruno-medeiros it landed just before the branch to beta, so I believe this will land in Rust 1.11, six weeks from today.

And will this need an upcoming GDB version, or will it work in existing GDB versions?

michaelwoerister · 2016-07-29T15:35:29Z

@bruno-medeiros

And will this need an upcoming GDB version, or will it work in existing GDB versions?

I think this should work with quite old versions of GDB.

@alexcrichton I think we should pass --with-python to ./configure.

alexcrichton · 2016-07-29T15:49:49Z

@michaelwoerister uh, sure! Remind me again which bot should pass which value though?

michaelwoerister · 2016-07-29T16:03:56Z

@alexcrichton I'm not sure what you mean. I was refering to this: https://github.com/rust-lang/rust-buildbot/blob/master/slaves/dist/build_gdb.sh#L15

alexcrichton · 2016-07-29T16:14:22Z

Oh right, I see what you mean! I'll give that a spin and see if it works.

bruno-medeiros · 2016-07-29T16:40:18Z

@michaelwoerister So this new thing: https://www.phoronix.com/scan.php?page=news_item&px=GNU-Toolchain-Q2-2016 is unrelated to this issue?

michaelwoerister · 2016-07-29T17:08:21Z

Yes, this is just an improvement to the Python-based pretty printers.

rust-highfive assigned aturon Jul 4, 2016

michaelwoerister reviewed Jul 4, 2016
View reviewed changes

michaelwoerister assigned michaelwoerister and unassigned aturon Jul 4, 2016

Use lazy iterator in vec/slice gdb pretty printers

5de76af

bors added a commit that referenced this pull request Jul 4, 2016

Auto merge of #34639 - dzamlo:master, r=michaelwoerister

d7ef1ac

Use lazy iterator in vec/slice gdb pretty printers

bors merged commit 5de76af into rust-lang:master Jul 5, 2016

alexcrichton mentioned this pull request Jul 5, 2016

Failure of pretty-huge-vec.rs on nightly bots #34662

Closed

alexcrichton mentioned this pull request Jul 5, 2016

test: Ignore pretty-huge-vec.rs to fix nightlies #34663

Closed

michaelwoerister mentioned this pull request Jul 7, 2016

rust-gdb mishandles very long vectors #29467

Closed

Uh oh!

Conversation

dzamlo commented Jul 4, 2016

Uh oh!

rust-highfive commented Jul 4, 2016

Uh oh!

michaelwoerister Jul 4, 2016

Choose a reason for hiding this comment

Uh oh!

dzamlo Jul 4, 2016

Choose a reason for hiding this comment

Uh oh!

michaelwoerister Jul 4, 2016

Choose a reason for hiding this comment

Uh oh!

michaelwoerister commented Jul 4, 2016

Uh oh!

dzamlo commented Jul 4, 2016

Uh oh!

srinivasreddy commented Jul 4, 2016

Uh oh!

michaelwoerister commented Jul 4, 2016

Uh oh!

dzamlo commented Jul 4, 2016

Uh oh!

michaelwoerister commented Jul 4, 2016

Uh oh!

michaelwoerister commented Jul 4, 2016

Uh oh!

bors commented Jul 4, 2016

Uh oh!

bors commented Jul 4, 2016

Uh oh!

bors commented Jul 5, 2016

Uh oh!

alexcrichton commented Jul 5, 2016

Uh oh!

bruno-medeiros commented Jul 7, 2016

Uh oh!

steveklabnik commented Jul 7, 2016

Uh oh!

bruno-medeiros commented Jul 29, 2016

Uh oh!

michaelwoerister commented Jul 29, 2016

Uh oh!

alexcrichton commented Jul 29, 2016

Uh oh!

michaelwoerister commented Jul 29, 2016

Uh oh!

alexcrichton commented Jul 29, 2016

Uh oh!

bruno-medeiros commented Jul 29, 2016

Uh oh!

michaelwoerister commented Jul 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants