-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Revert "Revert "Remove the return_address intrinsic."" #34648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f698cd3.
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
The Servo team are good with removing this once more. |
cc @rust-lang/core There has been an intent from you to get your hands dirty with this, so here’s the ping. |
also @rust-lang/lang and @rust-lang/compiler |
Note: apparently there’s a bunch of libcore copies out there (e.g. in redox), but the intrinsic is not actually used. These copies will begin to fail to build with nightlies once we remove the intrinsic, but in my eyes that’s acceptable. |
@nagisa AFAICT it's not a literal copy, but a submodule pointing to a fork of rust-lang/rust. |
Given that the affected users have signed off (as far as I know, this is basically just Servo), +1 from me. |
If servo is good, I'm good. 👍 |
@bors r=nagisa |
📌 Commit 0ec3d98 has been approved by |
Revert "Revert "Remove the return_address intrinsic."" This reverts commit f698cd3. Made possible by the merge of servo/servo#11872, this closes #34227 for good.
Apparently github didn't realize this was merged, closing. |
This reverts commit f698cd3.
Made possible by the merge of servo/servo#11872, this closes #34227 for good.