fix out-of-tree rustbuild #36853
Merged
fix out-of-tree rustbuild #36853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimNN
commented
Sep 30, 2016
| if !submodule.path.exists() { | ||
| t!(fs::create_dir_all(&submodule.path)); | ||
| t!(fs::create_dir_all(&submodule_path)); |
There was a problem hiding this comment.
Why do we need this?
State::NotInitializeddoes not need thisState::OutOfSyncshould have git create the directory when updating the submoduleState::MaybeDirtyshould not need this (I think): If the submodule is dirty, it already exists. Also the code would be ineffectual, since it creates just the directory and does not set up the.gitmetadata
There was a problem hiding this comment.
I agree, this shouldn't be required.
There was a problem hiding this comment.
This was needed to land the PR, but probably because the PR itself was buggy, want to try removing?
| // use `submodule.path` when e.g. executing a submodule specific command from the | ||
| // repository root | ||
| // use `submodule_path` when e.g. executing a normal git command for the submodule | ||
| // (set via `currnet_dir`) |
TimNN
force-pushed
the
rustbuild-out-of-tree
branch
from
a28f4d5 to
627463a
Compare
TimNN
force-pushed
the
rustbuild-out-of-tree
branch
from
627463a to
62fb242
Compare
|
@bors: r+ |
|
📌 Commit 62fb242 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 2, 2016
fix out-of-tree rustbuild See #36456 (comment) r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #36456 (comment)
r? @alexcrichton