rustc: Flag all builtins functions as hidden #37714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @japaric |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Travis failure seems legit: |
alexcrichton
force-pushed
the
builtins-hidden
branch
from
e4f1b15 to
e6148ff
Compare
|
Indeed! Hopefully fixed now |
arielb1
reviewed
Nov 12, 2016
| @@ -426,6 +426,14 @@ pub type OperandBundleDefRef = *mut OperandBundleDef_opaque; | |||
| pub type DiagnosticHandler = unsafe extern "C" fn(DiagnosticInfoRef, *mut c_void); | |||
| pub type InlineAsmDiagHandler = unsafe extern "C" fn(SMDiagnosticRef, *const c_void, c_uint); | |||
|
|
|||
| #[repr(C)] | |||
There was a problem hiding this comment.
Please add a comment to mark where the enum came from, or preferably write an LLVMRust wrapper.
When compiling compiler-rt you typically compile with `-fvisibility=hidden` which to ensure that all symbols are hidden in shared objects and don't show up in symbol tables. This is important for these intrinsics being linked in every crate to ensure that we're not unnecessarily bloating the public ABI of Rust crates. This should help allow the compiler-builtins project with Rust-defined builtins start landing in-tree as well.
alexcrichton
force-pushed
the
builtins-hidden
branch
from
e6148ff to
88b4646
Compare
|
@bors r+ |
|
📌 Commit 88b4646 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 15, 2016
rustc: Flag all builtins functions as hidden When compiling compiler-rt you typically compile with `-fvisibility=hidden` which to ensure that all symbols are hidden in shared objects and don't show up in symbol tables. This is important for these intrinsics being linked in every crate to ensure that we're not unnecessarily bloating the public ABI of Rust crates. This should help allow the compiler-builtins project with Rust-defined builtins start landing in-tree as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling compiler-rt you typically compile with
-fvisibility=hiddenwhich to ensure that all symbols are hidden in shared objects and don't show up
in symbol tables. This is important for these intrinsics being linked in every
crate to ensure that we're not unnecessarily bloating the public ABI of Rust
crates.
This should help allow the compiler-builtins project with Rust-defined builtins
start landing in-tree as well.