Skip to content

Specify the result of integer cast on boolean #39210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #39190.

r? @frewsxcv

@@ -12,7 +12,8 @@
//
/// The boolean type.
///
/// The `bool` represents a value, which could only be either `true` or `false`.
/// The `bool` represents a value, which could only be either `true` or `false`. If you cast
/// a `bool` into an integer, `true` will be 1 and `false` will be.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the 0.

@GuillaumeGomez
Copy link
Member Author

@rkruppe: Good catch, thanks!

@frewsxcv
Copy link
Member

If you wanted to, you could also add an example in the # Examples section. Otherwise, r=me

@GuillaumeGomez
Copy link
Member Author

I'll then, good idea!

@GuillaumeGomez
Copy link
Member Author

Added examples as well.

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 21, 2017

📌 Commit b09305e has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Jan 21, 2017

⌛ Testing commit b09305e with merge f5d1128...

bors added a commit that referenced this pull request Jan 21, 2017
Specify the result of integer cast on boolean

Fixes #39190.

r? @frewsxcv
@bors
Copy link
Collaborator

bors commented Jan 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing f5d1128 to master...

@bors bors merged commit b09305e into rust-lang:master Jan 21, 2017
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez-patch-1 branch January 22, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants